add percentage dimensions section to the Height and Width page#2101
Merged
Conversation
|
Deploy preview for react-native ready! Built with commit ae48b89 https://deploy-preview-2101--react-native.netlify.app Changes to Thank you for your contributions. |
|
Deploy preview for react-native ready! Built with commit 1b778e4 https://deploy-preview-2101--react-native.netlify.app Changes to Thank you for your contributions. |
nearestnabors
approved these changes
Jul 29, 2020
nearestnabors
left a comment
nearestnabors
left a comment
Contributor
There was a problem hiding this comment.
Thanks for expanding on this!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2071
Refs #2079
This PR adds the Percentage Dimensions section with a Snack example and short description (which for certain can be updated and phrased better 😉) to the Height and Width page.
I have also optimized a bit the readability of the other examples on that page.
Preview